-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-121645: Add support for new JSX Transform #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
hong6316
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hong6316
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0x64
pushed a commit
that referenced
this pull request
Feb 26, 2021
* 9037 Fix dotenv file loading order Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Upgrade to React 17 Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Revert react-refresh-webpack-plugin version Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Replace inquirer with prompts Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Replace inquirer with prompts in eject Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * 9374 Fix: use default modules option from preset-env Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 (#231) * PLAT-129601: Upgrade @pmmmwh/react-refresh-webpack-plugin module from 0.3.3 to 0.4.1 * Update CHANGELOG.md * Update package-lock.json * Update commands/eject.js (for fixing lint error) * Update package.json 2 * 9964 Add TypeScript 4.x as peerDependency Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * PLAT-129600: Replace deprecated eslint-loader by eslint-webpack-plugin (#235) * PLAT-129600: Replace eslint-loader to eslint-webpack-plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix lint Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * PLAT-121645: Add support for new JSX Transform (#236) * PLAT-121645: Add support for new JSX Transform Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix lint error Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix lint Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Added a guard Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependecies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Update @enact/moonstone-template dependency Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * added changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new JSX transform.
We could turn the feature off by setting
DISABLE_NEW_JSX_TRANSFORM
totrue
via.env
file forenact pack
.We can't turn the rule off for
enact lint
though.Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)