Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Ring from SGX attestation #60

Merged
merged 1 commit into from
Sep 29, 2022
Merged

chore: remove Ring from SGX attestation #60

merged 1 commit into from
Sep 29, 2022

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Sep 26, 2022

No description provided.

@rjzak rjzak force-pushed the removing_ring branch 13 times, most recently from bf0c292 to d4f455f Compare September 28, 2022 22:13
@rjzak rjzak changed the title Removing ring, piece by piece chore: removing Ring from SGX attestation Sep 28, 2022
@rjzak rjzak marked this pull request as ready for review September 28, 2022 22:36
@rjzak rjzak requested review from a team, bstrie and haraldh as code owners September 28, 2022 22:36
@rjzak
Copy link
Member Author

rjzak commented Sep 28, 2022

Aside from the commit squashing and re-wording, what else needs attention?

Should go after #62

@rjzak rjzak force-pushed the removing_ring branch 2 times, most recently from b54fd02 to 2fd2711 Compare September 29, 2022 13:07
@rjzak rjzak changed the title chore: removing Ring from SGX attestation chore: remove Ring from SGX attestation Sep 29, 2022
@npmccallum
Copy link
Member

@rjzak Ring still needs to be removed from deny.toml. This should include removing approved licenses we no longer need (like OpenSSL). You should also grep for any other remaining ring references.

@rjzak
chore: replace final Ring code with RustCrypto
cd88fb7 
Signed-off-by: Richard Zak <richard@profian.com>
@rjzak
Copy link
Member Author

rjzak commented Sep 29, 2022

Ring removed from deny.toml, and the only matches from grep are for lines with the word "String" of some kind.

@npmccallum npmccallum merged commit b775ff9 into enarx:main Sep 29, 2022
@rjzak rjzak deleted the removing_ring branch September 29, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmccallum npmccallum npmccallum approved these changes

@bstrie bstrie Awaiting requested review from bstrie

@haraldh haraldh Awaiting requested review from haraldh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjzak @npmccallum