-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wasm32-wasi support #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzak
force-pushed
the
wasi_rustcrypto
branch
10 times, most recently
from
October 4, 2022 13:42
1e31a6d
to
d22ad34
Compare
rvolosatovs
reviewed
Oct 4, 2022
rvolosatovs
reviewed
Oct 4, 2022
rvolosatovs
reviewed
Oct 4, 2022
rjzak
force-pushed
the
wasi_rustcrypto
branch
6 times, most recently
from
October 4, 2022 18:07
465bca2
to
4cc0b54
Compare
rvolosatovs
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better than before and is definitely moving the right direction!
rjzak
force-pushed
the
wasi_rustcrypto
branch
4 times, most recently
from
October 5, 2022 16:38
8c40d7d
to
07166bf
Compare
rvolosatovs
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress!
rvolosatovs
reviewed
Oct 5, 2022
rvolosatovs
approved these changes
Oct 5, 2022
rjzak
force-pushed
the
wasi_rustcrypto
branch
2 times, most recently
from
October 6, 2022 17:00
7af23c6
to
9bb8868
Compare
rvolosatovs
force-pushed
the
wasi_rustcrypto
branch
from
October 6, 2022 17:00
9bb8868
to
123793f
Compare
Signed-off-by: Richard Zak <richard@profian.com>
Signed-off-by: Richard Zak <richard@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs
force-pushed
the
wasi_rustcrypto
branch
3 times, most recently
from
October 6, 2022 17:33
e84e8d4
to
1f9cdea
Compare
rvolosatovs
force-pushed
the
wasi_rustcrypto
branch
from
October 6, 2022 18:02
1f9cdea
to
8278632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses RustCrypto, tests pass with both Wasmtime and Enarx!
Likely there will be requested changes to
.cargo/config
around the default target and preferred WebAssembly runtime.Signed-off-by: Richard Zak richard@profian.com