Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bhOptions #119

Closed
blond opened this issue Aug 14, 2015 · 6 comments
Closed

bhOptions #119

blond opened this issue Aug 14, 2015 · 6 comments
Assignees
Milestone

Comments

@blond
Copy link
Member

blond commented Aug 14, 2015

Use bhOptions instead of all options for provide to core:

  • jsAttrName
  • jsAttrScheme
  • jsCls
  • jsElem
  • escapeContent
  • clsNobaseMods

This change will allow:

  1. We do not need to release new versions of enb-bh if released minor versions of bh with new option.
  2. Test bh package before its release (see bhFilename option #118)
@blond blond self-assigned this Aug 14, 2015
@blond blond added this to the 1.0 milestone Aug 14, 2015
@sipayRT
Copy link
Contributor

sipayRT commented Aug 14, 2015

👍

@qfox
Copy link
Contributor

qfox commented Aug 14, 2015

Would you mind to declare peer dep for bh?

@blond
Copy link
Member Author

blond commented Aug 14, 2015

Would you mind to declare peer dep for bh?

What for?

@qfox
Copy link
Contributor

qfox commented Aug 14, 2015

Just to declare what version of bh it supports. NPM won't install it if it declared since npm/npm#6565 (comment) — so it will be pretty usable in 3.0

@blond
Copy link
Member Author

blond commented Aug 14, 2015

I think that it will be useful when most users will use npm@3.0. Now it will bring more problems than profit.

@qfox
Copy link
Contributor

qfox commented Aug 14, 2015

Ye, forgot about node 0.12 users. ;-( sorree

@blond blond mentioned this issue Aug 18, 2015
@blond blond added review and removed in progress labels Aug 18, 2015
@blond blond removed the review label Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants