Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bhOptions #122

Merged
merged 4 commits into from
Aug 19, 2015
Merged

bhOptions #122

merged 4 commits into from
Aug 19, 2015

Conversation

blond
Copy link
Member

@blond blond commented Aug 18, 2015

Resolved #119

@blond blond added the review label Aug 18, 2015
@blond
Copy link
Member Author

blond commented Aug 18, 2015

/cc @tadatuta @arikon @j0tunn

' clsNobaseMods: ' + opts.clsNobaseMods,
'});'
'bh.setOptions(' + JSON.stringify(opts.bhOptions),
');'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

имхо, закрывающая скобка логичнее будет смотреться на строке выше

@sipayRT
Copy link
Contributor

sipayRT commented Aug 19, 2015

@blond т.е. все же отказались от значений по умолчанию для всяких jsAttrs и т.д.? А этот мир мог бы быть таким красивым...

@blond
Copy link
Member Author

blond commented Aug 19, 2015

@sipayRT считаем, что пакет обёртка не должен подменять значения, а прокидывать их как есть.

Про красивый мир есть задача bem/bh#147

* В технологию `bh-common` добавлена опция [devMode](api.ru.md#devmode) ([#78]).
* В технологию [bh-bundle](api.ru.md#bh-bundle) добавлена опция [scope](api.ru.md#scope) ([#75], [#80]).
* В технологию [bh-commonjs](api.ru.md#bh-commonjs) добавлена опция [devMode](api.ru.md#devmode) ([#78]).
* [ __*major*__ ] В технологии [bh-bundle](api.ru.md#bh-bundle) и [bh-commonjs](api.ru.md#bh-commonjs) добавлена опция [bhOptions](api.ru.md#bhoptions) ([#119]). Её следует использовать вместо следующих опций, которые были удалены:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Её —>Ее

@blond
Copy link
Member Author

blond commented Aug 19, 2015

🆙

@sipayRT
Copy link
Contributor

sipayRT commented Aug 19, 2015

👍

blond added a commit that referenced this pull request Aug 19, 2015
@blond blond merged commit 98d4deb into master Aug 19, 2015
@blond blond removed the review label Aug 19, 2015
@blond blond deleted the issue-119 branch August 19, 2015 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants