Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imitate BEMHTML export behaviour #28

Merged
merged 1 commit into from
May 8, 2015
Merged

Imitate BEMHTML export behaviour #28

merged 1 commit into from
May 8, 2015

Conversation

tadatuta
Copy link
Member

Closes #27

'module.exports = bh;'
'module.exports = bh;',
this._mimic.map(function (name) {
return 'bh.' + name + ' = bh;';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return 'bh[' + name + '] = bh;';

@tadatuta tadatuta force-pushed the master branch 3 times, most recently from ceca85f to 7c3bde8 Compare March 14, 2015 22:19
@tadatuta tadatuta force-pushed the master branch 2 times, most recently from 0da709f to ef3aeac Compare May 8, 2015 19:31
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.57%) to 97.58% when pulling ef3aeac on tadatuta:master into a7bd4d4 on enb-bem:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.77%) to 98.39% when pulling 1ad50d5 on tadatuta:master into a7bd4d4 on enb-bem:master.

@@ -71,6 +71,26 @@ describe('bh-client-module', function () {
return runTest(test, options);
});

it('mimic to different template engines', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно обернуть тесты на mimic в общий describe.

@blond
Copy link
Member

blond commented May 8, 2015

Не хватает тестов для bh-server-include и bh-client технологий.

@tadatuta
Copy link
Member Author

tadatuta commented May 8, 2015

Не хватает тестов для bh-server-include и bh-client технологий.

да что ж вы за люди-то такие, зачем вам 100% покрытие, если там по смыслу одно и то же под капотом зовется?
сделаю, конечно )

@blond
Copy link
Member

blond commented May 8, 2015

да что ж вы за люди-то такие, зачем вам 100% покрытие, если там по смыслу одно и то же под капотом зовется?

Это разный код, если сломают в одной технологии, то не факт, что заметят в другой.

@tadatuta
Copy link
Member Author

tadatuta commented May 8, 2015

Это разный код

Потому я и прошу выпилить выгон технологий в пользу одной с опциями, чтобы не плодить копипаст в технологиях -> копипаст в тестах -> радости изучения и поддержки этого всего

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.19% when pulling fff5744 on tadatuta:master into a7bd4d4 on enb-bem:master.

@@ -12,7 +12,7 @@
* (его предоставляет технология `files`). По умолчанию — `?.files`.
* * *String* **sourceSuffixes** — суффиксы файлов, по которым строится `files`-таргет. По умолчанию — ['bh'].
* * *Boolean* **sourcemap** — строить карты кода.
* * *String* **mimic** — имя модуля для экспорта.
* * *String|Array* **mimic** — имя модуля для экспорта.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Имена модуей

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.19% when pulling f0543a6 on tadatuta:master into a08c4aa on enb-bem:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.19% when pulling 66c5c6c on tadatuta:master into a08c4aa on enb-bem:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.19% when pulling d76cb17 on tadatuta:master into a08c4aa on enb-bem:master.

blond added a commit that referenced this pull request May 8, 2015
Imitate BEMHTML export behaviour
@blond blond merged commit ebe76d9 into enb:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imitate BEMHTML export behaviour
3 participants