-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Tech #60
Bundle Tech #60
Conversation
|
||
// Core | ||
file.writeFileContent(core.path, core.contents); | ||
file.writeLine('var bh = new BH();'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think such variant is more readable:
[
'var bh = new BH();',
'bh.setOptions({',
' jsAttrName: \'' + opts.jsAttrName + '\',',
' jsAttrScheme: \'' + opts.jsAttrScheme + '\',',
' jsCls: ' + (opts.jsCls ? ('\'' + opts.jsCls + '\'') : false),
'});'
].forEach(function(line) { file.writeLine(line); });
5b3fcb4
to
d1872c3
Compare
63d985c
to
3520905
Compare
'bh.setOptions({', | ||
' jsAttrName: "' + opts.jsAttrName + '",', | ||
' jsAttrScheme: "' + opts.jsAttrScheme + '",', | ||
' jsCls: ' + (opts.jsCls ? ('"' + opts.jsCls + '"') : 'false'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а зачем false
в кавычках?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
При конкатенации оно всё равно превратится в строку.
f698dbb
to
4046c5c
Compare
Resolved #22
bh-client
,bh-client-module
andbh-server-include
tobh-bundle
tech.bh-server
tobh-commonjs
.