Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Tech #60

Merged
merged 5 commits into from
May 18, 2015
Merged

Bundle Tech #60

merged 5 commits into from
May 18, 2015

Conversation

blond
Copy link
Member

@blond blond commented May 15, 2015

Resolved #22

  • Merged bh-client, bh-client-module and bh-server-include to bh-bundle tech.
  • Renamed bh-server to bh-commonjs.

@blond blond changed the title Bundle Tech [WIP] Bundle Tech May 15, 2015

// Core
file.writeFileContent(core.path, core.contents);
file.writeLine('var bh = new BH();');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think such variant is more readable:

[
    'var bh = new BH();',
    'bh.setOptions({',
    '    jsAttrName: \'' + opts.jsAttrName + '\',',
    '    jsAttrScheme: \'' + opts.jsAttrScheme + '\',',
    '    jsCls: ' + (opts.jsCls ? ('\'' + opts.jsCls + '\'') : false),
    '});'
].forEach(function(line) { file.writeLine(line); });

@blond blond force-pushed the issue-22 branch 2 times, most recently from 5b3fcb4 to d1872c3 Compare May 15, 2015 22:58
@blond blond force-pushed the issue-22 branch 2 times, most recently from 63d985c to 3520905 Compare May 16, 2015 17:21
@blond blond changed the title [WIP] Bundle Tech Bundle Tech May 16, 2015
'bh.setOptions({',
' jsAttrName: "' + opts.jsAttrName + '",',
' jsAttrScheme: "' + opts.jsAttrScheme + '",',
' jsCls: ' + (opts.jsCls ? ('"' + opts.jsCls + '"') : 'false'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем false в кавычках?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При конкатенации оно всё равно превратится в строку.

@blond blond force-pushed the issue-22 branch 4 times, most recently from f698dbb to 4046c5c Compare May 18, 2015 17:18
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 100.0% when pulling d29de94 on issue-22 into a9807f3 on master.

blond added a commit that referenced this pull request May 18, 2015
@blond blond merged commit b3061a3 into master May 18, 2015
@blond blond removed the in progress label May 18, 2015
@blond blond deleted the issue-22 branch May 18, 2015 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use one tech for global scope and module system
4 participants