#12 Add sourcemap option to browser-js technology #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .builder(function (sourceFiles) { | ||
| return this._readSourceFiles(sourceFiles) | ||
| .then(function (sources) { | ||
| var file = new File(this.node.resolvePath(this._target), this._sourcemap), |
There was a problem hiding this comment.
второй параметр должен быть объектом: {sourceMap: this._sourcemap}. Boolean тоже обрабатывается, но по хорошему со временем это нужно будет выпилить
|
В остальном 🆗 |
|
Если указать одновременно Как поддержать карты кода в |
|
Посмотри пожалуйста. |
| EOL = require('os').EOL; | ||
| var vow = require('vow'), | ||
| vfs = require('enb/lib/fs/async-fs'), | ||
| Utils = require('enb-source-map/lib/utils'), |
There was a problem hiding this comment.
Почему с большой буквы? Это же немспейс.
|
Написал пару замечаний. |
|
🆙 |
|
🆗 |
tormozz48
added a commit
that referenced
this pull request
Sep 8, 2015
#12 Add sourcemap option to browser-js technology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #12
@blond @j0tunn
Please review it