Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #38

Merged
merged 1 commit into from
Sep 16, 2015
Merged

Update changelog #38

merged 1 commit into from
Sep 16, 2015

Conversation

tormozz48
Copy link
Contributor

Resolve #36

@blond @tadatuta

Please review it


#### Опции технологий

* В технологию [browser-js](api.ru.md#browser-js) добавлена опция [iife](api.ru.md#iife) ([#6]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно избавится от копипаста, начав с «В технологию browser-js были добавлены опции:»

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Просто перечисление опций выглядит скучноватым и не понятными. Надо в первую очередь перечислить какие фичи появились.

@tormozz48
Copy link
Contributor Author

🆙


### Новая функциональность

* Добавлена возможность изоляции выполняемого кода исходных модулей [iife](api.ru.md#iife) ([#6]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно сократить до:

Изоляция кода ([#6]).

Но надо дать ссылку на документацию.

@tormozz48
Copy link
Contributor Author

🆙


* [Изоляция кода](api.ru.md#iife) ([#6]).
* [Минимизация кода](api.ru.md#compress) ([#30]).
* Поддержка карт кода [(source maps)](api.ru.md#sourcemap) ([#12]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ссылку логичнее дать на текст вне скобок.

@blond
Copy link
Member

blond commented Sep 14, 2015

Надо добавить ссылок для ишью и PR'ов в конец файла.

@tormozz48
Copy link
Contributor Author

🆙

@blond
Copy link
Member

blond commented Sep 15, 2015

Мне 🆗, но давай вливать после документации.

@tormozz48
Copy link
Contributor Author

Объединил коммиты

blond added a commit that referenced this pull request Sep 16, 2015
@blond blond merged commit 2dcefd4 into master Sep 16, 2015
@blond blond removed the review label Sep 16, 2015
@blond blond deleted the issue-36 branch September 16, 2015 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants