Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | .GetAssayData | Incorrect assumptions about SeuratObject versions #38

Closed
mojaveazure opened this issue Sep 16, 2023 · 1 comment · Fixed by #39
Closed

BUG | .GetAssayData | Incorrect assumptions about SeuratObject versions #38

mojaveazure opened this issue Sep 16, 2023 · 1 comment · Fixed by #39

Comments

@mojaveazure
Copy link
Contributor

Code for .GetAssayData() assumes that SeuratObject v4.1.3 is the last version of SeuratObject for the v4 cycle https://github.com/enblacar/SCpubr/blob/main/R/utils.R#L3283-L3290
This assumption is incorrect; we are trying to submit v4.1.4 to handle the upcoming removal of rgeos from CRAN, and this assumption in SCpubr will cause failures in our upcoming submission

For reference, SeuratObject::GetAssayData() will continue to work in SeuratObject v5 and will work for both v3 and v5 assays. Once v5 is released, we will eventually start throwing warnings about the usage of GetAssayData() and move users and downstream packages to LayerData(), but that will not happen until SeuratObject v5.1 at the earliest (and may be later). But as SeuratObject v5 is not on CRAN, v5 assumptions should not be made in packages that are also on CRAN

@enblacar
Copy link
Owner

Hi @mojaveazure,

Sorry for the late reply! Many, many thanks for taking the time to point this problem out!

I will update the code ASAP to fix this and submit a hotfix to CRAN.

Best,
Enrique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants