Replace .GetAssayData() with SeuratObject::GetAssayData()
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom data accessors with Seurat-provided accessors (`GetAssayData()`. `GetAssayData()` will continue to work in v5 on both v3 and v5 assays and will not throw deprecation warnings or errors in downstream packages until well into the v5 lifecyle. Should we decide to end usage of `GetAssayData()`, we will let you and other downstream packages know well ahead of time
|
Many thanks for the merge request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom data accessors with Seurat-provided accessors (
GetAssayData().GetAssayData()will continue to work in v5 on both v3 and v5 assays and will not throw deprecation warnings or errors in downstream packages until well into the v5 lifecyle. Should we decide to end usage ofGetAssayData(), we will let you and other downstream packages know well ahead of timeresolves #38