Fix rootless install #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a host system, dockerd rootless is installed with the dockerd-rootless-setuptool.sh script. When using in dind mode the setuptool script no longer works because rootlesskit is run in order to test that the install was successful. This isn't possible because rootlesskit would need to run privileged at build time. The rootlesskit supplied install scripts are rewritten to only include whats needed to run in dind mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12
Relates to rootless-containers/rootlesskit#425
On a host system, dockerd rootless is installed with the
dockerd-rootless-setuptool.sh script. When using in dind mode the
setuptool script no longer works because rootlesskit is run in order to
test that the install was successful. This isn't possible because
rootlesskit would need to run privileged at build time.
The rootlesskit supplied install scripts are rewritten to only include
whats needed to run in dind mode.