-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgresql+asyncpg scheme prefix (closes #395) #396
Conversation
Ok, I bring this up only because SQLAlchemy supports the format More background: I'm writing a FastAPI project and using fastapi-users which requires Databases. So I'm stuck having to supply a DB URL to both libraries. Ideally these should be able to be the same, and since one's built on the other, they shouldn't act differently anyway. If it's not ok to have multiple mappings for a backend (i.e. specifying all valid schemes), I propose the following strategy:
|
I agree that making it specific |
ok sounds good, will write the test asap
… On Sep 23, 2021, at 15:45, Amin Alaee ***@***.***> wrote:
I agree that making it specific dialect+driver looks better. But as you said if we could handle both cases it would be great for backwards-compatibility too.
This just needs the missing test coverage, and we can merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I fixed the rest of tests.
No description provided.