[self-tests] cleanup order of TestUrlPatternTestCase
#9399
Comments
stanislavlevin
added a commit
to stanislavlevin/django-rest-framework
that referenced
this issue
May 6, 2024
According to docs: https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup > Add a function to be called after tearDownClass() to cleanup resources used during the test class. Functions will be called in reverse order to the order they are added (LIFO). This was revealed with recent change in pytest (`8.2.0`): > pytest-dev/pytest#11728: For unittest-based tests, exceptions during class cleanup (as raised by functions registered with TestCase.addClassCleanup) are now reported instead of silently failing. `check_urlpatterns` is called before `cleanup_url_patterns` and fails (problem was hidden by `pytest < 8.2.0`). `doClassCleanups` can be used instead to check after-cleanup state: https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups > This method is called unconditionally after tearDownClass(), or after setUpClass() if setUpClass() raises an exception. It is responsible for calling all the cleanup functions added by addClassCleanup(). If you need cleanup functions to be called prior to tearDownClass() then you can call doClassCleanups() yourself. Fixes: encode#9399 Signed-off-by: Stanislav Levin <slev@altlinux.org>
|
thanks for the report and fix |
auvipy
pushed a commit
that referenced
this issue
May 7, 2024
According to docs: https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup > Add a function to be called after tearDownClass() to cleanup resources used during the test class. Functions will be called in reverse order to the order they are added (LIFO). This was revealed with recent change in pytest (`8.2.0`): > pytest-dev/pytest#11728: For unittest-based tests, exceptions during class cleanup (as raised by functions registered with TestCase.addClassCleanup) are now reported instead of silently failing. `check_urlpatterns` is called before `cleanup_url_patterns` and fails (problem was hidden by `pytest < 8.2.0`). `doClassCleanups` can be used instead to check after-cleanup state: https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups > This method is called unconditionally after tearDownClass(), or after setUpClass() if setUpClass() raises an exception. It is responsible for calling all the cleanup functions added by addClassCleanup(). If you need cleanup functions to be called prior to tearDownClass() then you can call doClassCleanups() yourself. Fixes: #9399 Signed-off-by: Stanislav Levin <slev@altlinux.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tests/test_testing.py::TestUrlPatternTestCase::test_urlpatternsfails againstpytest 8.2.0:This was revealed with recent change in pytest (
8.2.0):This is actual problem of the test.
https://docs.python.org/3/library/unittest.html#unittest.TestCase.addClassCleanup
check_urlpatternsis called beforecleanup_url_patternsand fails (problem was hidden bypytest < 8.2.0).The text was updated successfully, but these errors were encountered: