Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight select_related and prefetch_related usage in documentation #7610

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

thetarby
Copy link
Contributor

Hi, I have tried to update documentation to cover details about possible n+1 problems and how to avoid them. I think this should close the documentation ticket #1977

@thetarby
Copy link
Contributor Author

Anyone has any feedback? I think documenting possible causes of n+1 problem is a needed improvement in docs.

Copy link
Collaborator

@xordoquy xordoquy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Got 2 cosmetic changes and I'll merge it.

docs/api-guide/relations.md Outdated Show resolved Hide resolved
docs/api-guide/relations.md Outdated Show resolved Hide resolved
thetarby and others added 2 commits December 31, 2020 21:43
cosmetic changes

Co-authored-by: Xavier Ordoquy <xordoquy@linovia.com>
@tomchristie tomchristie merged commit 6ea95b6 into encode:master Oct 5, 2021
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
…ion (encode#7610)

* docs updated to highlight use of select_related and prefetch related to avoid n+1 problems

* Apply suggestions from code review

cosmetic changes

Co-authored-by: Xavier Ordoquy <xordoquy@linovia.com>

* cosmetic changes

Co-authored-by: Xavier Ordoquy <xordoquy@linovia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants