-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix raising on nullable fields part of UniqueConstraint
#9531
Fix raising on nullable fields part of UniqueConstraint
#9531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any progress here?
Not really, I've dropped the ball a bit on this one. Will try to make some progress... |
Oh well, that's all passing now... Hopefully that covers the main use case reported in https://github.com/encode/django-rest-framework/issues/9378 There is also the other semi-related bug https://github.com/encode/django-rest-framework/issues/9358 which is NOT in scope of this PR, I believe it will be fixed by #9360 |
Is a new version expected with this fix and others related like #9360 ? The support for UniqueConstraint is not complete and may cause issues… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks! |
Description
Fix #9378