Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to GitHub Issues and Discussions #9660

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

mbeijen
Copy link
Contributor

@mbeijen mbeijen commented Feb 28, 2025

@ulgens
Copy link
Contributor

ulgens commented Mar 1, 2025

I don't think that issues and discussions are deactivated for good, this is more of a temporary thing until the project gains its momentum back. Removing the references seems not ideal.

@iTrooz
Copy link

iTrooz commented Mar 2, 2025

Wish we could at least see the old issues/discussions. So much knowledge lost

@auvipy
Copy link
Member

auvipy commented Mar 3, 2025

I'm not sure why discussion is deactivated!

tomchristie
tomchristie previously approved these changes Mar 3, 2025
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mbeijen, much appreciated.

Given that they are not currently activated it seems(?) reasonable enough to get the docs updated.

This pull request will remain in the history, and we can revert if/when appropriate at a later date.

@tomchristie
Copy link
Member

I'm not sure why discussion is deactivated!

Some reasons here...

  • I feel that the project's discussion working space doesn't present the kind of environment I'd like to be working in.
  • Much of the discussion and issue space isn't being properly directed at the moment and feels to me like its creating a distraction/drag on attention, rather than being genuinely valuable.

An option might be to make them public again, but put interaction limits on the repository to prevent ongoing churn. That would resolve the second part of my concerns but doesn't address helping clean up the initial part.

@hyperstown
Copy link

@tomchristie would it be possible to make issues and discussions read only for now? I believe those had a lot of useful information that currently is not accessible.

Also does that also mean that project currently doesn't accept any new features? Only bug/security fixes?

@sethrh
Copy link

sethrh commented Mar 5, 2025

My team just started using DRF, and we're two months in on a major project. It's really unsettling to see a huge source of information about how real people use the framework (bug reports) just disappear.

As a developer, particularly one new to the framework, I rely on issue lists to see if problems I'm running into are correct or incorrect behavior, known issues, if other people have encountered them, if I'm doing it wrong, etc.

I'm not sure what the reasons are for turning off issues here on GitHub, but if there's some problem, please consider turning the issues back on while the problem is resolved.

@tomchristie
Copy link
Member

Yes, tho...

The issue here is that there a problematic environment across the entire GitHub ecosystem that's become normalised.

Anonymous contributors demanding attention in ways that both intentionally and unintentionally end up as a DDOS on project maintainers.

I'm putting a hard limit on this at the moment to reset expectations.

@tomchristie
Copy link
Member

would it be possible to make issues and discussions read only for now?

I have been considering this yes. GitHub doesn't really have controls to allow that, tho it does have a work around in the form of interaction limits.

@encode encode deleted a comment from iTrooz Mar 6, 2025
@aliraad79
Copy link

Hi, there is also a reference to #5181 in this link you should consider deleting this too

@mbeijen
Copy link
Contributor Author

mbeijen commented Mar 8, 2025

Hi, there is also a reference to #5181 in this link you should consider deleting this too

Thanks, I've updated my PR.

Unfortunately, my updating the PR removed the approval by @tomchristie and also it's not merged yet. I'm sorry for the extra work ;-(

@auvipy
Copy link
Member

auvipy commented Mar 8, 2025

can we make them collaborators only or read only if possible?

@joshorr
Copy link

joshorr commented Mar 18, 2025

I'm not sure why discussion is deactivated!

Some reasons here...

  • I feel that the project's discussion working space doesn't present the kind of environment I'd like to be working in.
  • Much of the discussion and issue space isn't being properly directed at the moment and feels to me like its creating a distraction/drag on attention, rather than being genuinely valuable.

An option might be to make them public again, but put interaction limits on the repository to prevent ongoing churn. That would resolve the second part of my concerns but doesn't address helping clean up the initial part.

@tomchristie Sorry for the interruption, but I had a thought on this subject that might help.

It sounds like you can limit the interaction with them, and that resolves your second concern.

As for your first concern: If there is no longer any new issues or interactions happening in them, then it means you would have no reason or need to work/examine them any longer. I am thinking that it may resolve your first concern, as you would have no reason to be working in/on the issues since nothing new could be posted in them?

I also remember seeing something on this project recently (not sure if it was a discussion/issue or somewhere else, can't seem to find it anymore) that talked about how this project was in a mature state and generally only changes that helped adapt the DRF to changes in the last Django versions would be the ones generally being accepted/merged in.

It seems like making the discussions public but read-only/non-interactive would be in that same general spirit, ie: keeping things how they are, not adding new features, are and only adapting to changes in the framework's dependencies.

Background:

Some of the issue had generally useful information in them. I am thinking making it visible in some way would be a greater benefit than hiding them.

Yes, it does hide the non-useful discussion, but the cost is hiding all of the genuinely useful ones as well. I remember a number of very useful discussions that helped me use this framework over the years. I would love to see them visible again so I can continue to reference them.

@browniebroke
Copy link
Member

To make issues ready-only I searched and found this hacky solution: https://github.com/orgs/community/discussions/64600#discussioncomment-8713177.

I created a repo to test it: it prevents creation of new issues and doesn't prevent commenting on the ones which are already open, but we could lock all existing ones. I don't think it's easy to do in bulk via the UI, but we could script that with the gh command line/their API...

@shuuji3
Copy link
Contributor

shuuji3 commented Mar 28, 2025

Hi, GitHub's interactions limit feature might be helpful here, though it does not have so much granular control. It allows you to temporarily restrict contributions to a specific group, still allowing others to access to the precious knowledge base. I think this feature was created for a situation like this. I hope this helps for healthy open source maintenance 🙂

Temporary interaction limit

@browniebroke
Copy link
Member

Going to merge this as is as it's reflecting the current state of the project 👍🏻 Thanks everyone

@browniebroke browniebroke merged commit ffadde9 into encode:master Mar 31, 2025
8 checks passed
@browniebroke browniebroke added this to the 3.16 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.