Bigint coerce to string #9775
Open
Bigint coerce to string #9775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can have string api representation
|
Any news? |
peterthomassen
requested changes
Oct 9, 2025
|
|
||
| * `max_value` Validate that the number provided is no greater than this value. | ||
| * `min_value` Validate that the number provided is no less than this value. | ||
| * `coerce_to_string` Set to `True` if string values should be returned for the representation, or `False` if `BigInteger` objects should be returned. Defaults to the same value as the `COERCE_BIGINT_TO_STRING` settings key, which will be `True` unless overridden. If `BigInterger` objects are returned by the serializer, then the final output format will be determined by the renderer. |
|
|
||
| When returning biginteger objects in API representations that do not support numbers up to 2^64, it is best to return the value as a string. This avoids the loss of precision that occurs with biginteger implementations. | ||
|
|
||
| When set to `True`, the serializer `BigIntegerField` class will return strings instead of `BigInteger` objects. When set to `False`, serializers will return `BigInteger` objects, which the default JSON encoder will return as numbers. |
There was a problem hiding this comment.
add (by default) after "class", as it can be overridden
rest_framework/serializers.py
Outdated
| ) | ||
| from rest_framework.exceptions import ErrorDetail, ValidationError | ||
| from rest_framework.fields import get_error_detail | ||
| from rest_framework.fields import get_error_detail, BigIntegerField |
There was a problem hiding this comment.
move the addition to the block starting in line 55
|
|
||
| def test_force_coerce_to_string(self): | ||
| field = serializers.BigIntegerField(coerce_to_string=True) | ||
| assert isinstance(field.to_representation(int('1')), str) |
There was a problem hiding this comment.
Why int('1')?
And why only test the type, not the value itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Bigint coerce to string missing
Creates a new type
BigIntegerFieldto mapdjango.models.BigIntegerFieldand solve the problemFix #9733