Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pproxy from 2.3.5 to 2.3.7 #212

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 5, 2020

Bumps pproxy from 2.3.5 to 2.3.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 5, 2020
@dependabot dependabot bot force-pushed the dependabot/pip/pproxy-2.3.7 branch 2 times, most recently from 339be6b to 23dad24 Compare October 5, 2020 10:27
@florimondmanca
Copy link
Member

These patch updates are a bit noisy. Not sure if there's away to tell Dependabot to:

  • Auto-merge once PR is approved and any rebased have finished.
  • Alternatively, skip patch level dependency bumps?

@dependabot dependabot bot force-pushed the dependabot/pip/pproxy-2.3.7 branch from 23dad24 to e35bb51 Compare October 5, 2020 13:45
@dependabot dependabot bot force-pushed the dependabot/pip/pproxy-2.3.7 branch from e35bb51 to c53334d Compare October 5, 2020 13:49
@jcugat
Copy link
Member

jcugat commented Oct 5, 2020

@florimondmanca it doesn't seem possible to auto-merge PR's directly.

Regarding skipping patch bumps, I see two options:

  1. Increase the schedule interval to monthly. If there are multiple minor bumps during a month for the same dependency, we would only get the PR for the latest one.

  2. Ignore some specific versions for dependencies. For example, we could ignore pproxy==2.3.x so the next bump we get would be from the v2.4 minor range.

What do you think?

@cdeler
Copy link
Member

cdeler commented Oct 5, 2020

@jcugat

Do you know if it's possible to combine all the update changes in one PR?

E.g. to run the bot pipeline weekly, creating a commit with all weekly changes and a pr with the changes?

Or may be the dev dependencies updates might be performed per release basis? (I do it this way on my work project, but we have a regular releases)

Then workflow might look like:

  1. increment patch version
  2. write changelog
  3. run script/update_dependencies
  4. make a release commit

@StephenBrown2
Copy link

Weekly seems fine to me, Dependabot will also close out outdated PRs if a new version gets released before the old one is approved/merged.

I don't think that combining the PRs would be good, as it may make breaking issues harder to debug, but an update_dependencies script may be a good idea.

@jcugat
Copy link
Member

jcugat commented Oct 5, 2020

No, combining bumps in the same PR is not possible unfortunately.

@tomchristie
Copy link
Member

Switching to monthly is a good plan - we don't particularly need regular updates on our tooling.

The important thing is that we're using pinned version for our build, not that we're always up-to-date with the very very latest tooling versions.

@florimondmanca
Copy link
Member

Agreed with @tomchristie — if there's a monthly schedule then I think I'd be up for us switching to that. 👍

@jcugat jcugat merged commit 57852f1 into master Oct 6, 2020
@jcugat jcugat deleted the dependabot/pip/pproxy-2.3.7 branch October 6, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants