Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to treat warnings as errors #1686

Closed
tomchristie opened this issue Jun 15, 2021 · 0 comments · Fixed by #1687
Closed

Switch CI to treat warnings as errors #1686

tomchristie opened this issue Jun 15, 2021 · 0 comments · Fixed by #1687
Labels
tooling Changes to our CI/CD, tests setup, etc.

Comments

@tomchristie
Copy link
Member

Prompted by #1670

Since merging #1682 we're now including test runs for Python 3.10 beta.
Issue #1670 notes that we've got a deprecation warning being raised on 3.10.
The sensible approach in terms of process here is to make sure that our CI is erroring on deprecation warnings, so that we're seeing these cases up front, and able able to validate that we've resolved them, and know if we ever unintentionally introduce a regression.

So first step here prior to considering #1670 should be to upgrade our warnings to errors.

That'll also highlight that we've got an existing case on 3.8 and 3.9 of a test cases that's causing a warning that ought to be resolve. (See https://github.com/encode/httpx/pull/1682/checks?check_run_id=2828639691)

@tomchristie tomchristie added the tooling Changes to our CI/CD, tests setup, etc. label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to our CI/CD, tests setup, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant