👷 Add Python 3.10 beta to the CI #1682

Kludex · 2021-06-13T10:40:39Z

Closes #1678.

EDIT: Failing due to mypy. - @Kludex
EDIT: Changed "Related to #...." to "Closes #...." - @tomchristie

tomchristie · 2021-06-14T13:50:09Z

Okay, so #1679 resolves the unrelated mypy failure, which is now merged in.

We've got a curious failure on the 3.10 test run, which I don't understand on first glance.

Kludex · 2021-06-14T13:59:38Z

It's due to pytest. We need to upgrade to the latest 6.2.4 if we want to add Python 3.10.

Can I proceed?

Reference:

tomchristie · 2021-06-14T14:14:59Z

Yup, makes sense.

I'm assuming you'll want to update this line:

httpx/requirements.txt

Line 23 in 4a3e5e1

pytest==5.*

Switching it to pytest==6.*, and do that as part of this pull request.

…beta

…o ci/add-python-3.10-beta

Kludex · 2021-06-14T14:26:33Z

Now there's an issue with trio. 😅

Reference: python-trio/trio#1899

tomchristie · 2021-06-14T14:27:32Z

Hrrrmmm.... I'm not entirely surprised that we've got a different failure there. After all, we will have pinned pytest for a reason.

However, looking at the blame view for the requirements file isn't super helpful here...

The pin was introduced in this commit but it doesn't have an associated PR, and doesn't include the rationale. (We're way cleaner on process here now, as things have evolved nicely)

That one looks like it needs some further digging.

tomchristie · 2021-06-14T14:29:43Z

I'd assume it's a pytest/trio interaction issue, rather than "an issue with trio" or "an issue with pytest", but... (?)

tomchristie · 2021-06-14T14:30:47Z

Now there's an issue with trio. 😅

Reference: python-trio/trio#1899

Ah gotcha, thanks!

tomchristie · 2021-06-14T14:32:02Z

Okay, so I think we're hard blocked by that one, on adding 3.10 to the matrix. Right?

(Which is totally okay, just making sure we've got the same assessment on that.)

tomchristie · 2021-06-14T14:33:44Z

Looks to me like python-trio/trio#1921 will resolve this, and seems pretty much good to go.

tomchristie · 2021-06-14T14:35:35Z

.github/workflows/test-suite.yml

@@ -14,7 +14,7 @@ jobs:

 strategy:
 matrix:
- python-version: ["3.6", "3.7", "3.8", "3.9"]
+ python-version: ["3.6", "3.7", "3.8", "3.9", "3.10.0-beta.2"]


Can we just use "3.10" here?

Why? / Why not?

Prompted by noticing the same in a Trio pull request.
Also, useful for context here... where does GitHub document the supported values for python-version?

Note the extra bit in trio.

https://github.com/python-trio/trio/pull/1921/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR44-R52

# This allows the matrix to specify just the major.minor version while still # expanding it to get the latest patch version including alpha releases. # This avoids the need to update for each new alpha, beta, release candidate, # and then finally an actual release version. actions/setup-python doesn't # support this for PyPy presently so we get no help there. # # CPython -> 3.9.0-alpha - 3.9.X # PyPy -> pypy-3.7 python-version: ${{ fromJSON(format('["{0}", "{1}"]', format('{0}.0-alpha - {0}.X', matrix.python), matrix.python))[startsWith(matrix.python, 'pypy')] }}

Also https://github.com/actions/setup-python#available-versions-of-python and if you search for range you can see it show up in a couple comments. All around not entirely explicitly documented, but useful.

Should I follow trios lead and use the same logic?

Should I follow trios lead and use the same logic?

Perhaps, perhaps not, but either way let's not consider it as part of this pull request.

tomchristie · 2021-06-14T14:37:47Z

tests/conftest.py

@@ -164,7 +165,7 @@ async def redirect_301(scope, receive, send):
 await send({"type": "http.response.body"})


-SERVER_SCOPE = "session"
+SERVER_SCOPE: Literal["session"] = "session"


Few questions, for thoroughness. 😁

What's prompting this change?

Is it strictly necessary for us to type this variable, here?

Do we have a build failure without it?

Can it simply be str?

It's precisely because it identifies it as str that we need it. This is the mypy issue:

+ mypy httpx tests tests/conftest.py:170: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:170: note: Possible overload variant: tests/conftest.py:170: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:170: note: <1 more non-matching overload not shown> tests/conftest.py:175: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:175: note: Possible overload variant: tests/conftest.py:175: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:175: note: <1 more non-matching overload not shown> tests/conftest.py:181: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:181: note: Possible overload variant: tests/conftest.py:181: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:181: note: <1 more non-matching overload not shown> tests/conftest.py:186: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:186: note: Possible overload variant: tests/conftest.py:186: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:186: note: <1 more non-matching overload not shown> tests/conftest.py:192: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:192: note: Possible overload variant: tests/conftest.py:192: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:192: note: <1 more non-matching overload not shown> tests/conftest.py:198: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:198: note: Possible overload variant: tests/conftest.py:198: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:198: note: <1 more non-matching overload not shown> tests/conftest.py:274: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:274: note: Possible overload variant: tests/conftest.py:274: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:274: note: <1 more non-matching overload not shown> tests/conftest.py:281: error: No overload variant of "fixture" matches argument type "str" tests/conftest.py:281: note: Possible overload variant: tests/conftest.py:281: note: def fixture(fixture_function: None = ..., *, scope: Union[Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']], Callable[[str, Config], Union[Literal['session'], Literal['package'], Literal['module'], Literal['class'], Literal['function']]]] = ..., params: Optional[Iterable[object]] = ..., autouse: bool = ..., ids: Union[Iterable[Union[None, str, float, int, bool]], Callable[[Any], Optional[object]], None] = ..., name: Optional[str] = ...) -> FixtureFunctionMarker tests/conftest.py:281: note: <1 more non-matching overload not shown> Found 8 errors in 1 file (checked 57 source files)

Do you have an alternative suggestion?

Do you have an alternative suggestion?

Nope. Just making sure I understand e'rything going in, and we've got a super clear history in place throughout. 😀

graingert · 2021-06-14T20:53:45Z

related: #1671

pquentin · 2021-06-15T10:20:09Z

I just released Trio 0.19.0 with Python 3.10 support. ✨

tomchristie · 2021-06-15T10:52:41Z

👏 Fantastic, thanks @pquentin - I've triggered a test re-run now.

👷 Add Python 3.10 beta to the CI

ae2ed62

Kludex added enhancement New feature or request tooling Changes to our CI/CD, tests setup, etc. labels Jun 13, 2021

Merge branch 'master' into ci/add-python-3.10-beta

96de53d

Kludex added 3 commits June 14, 2021 16:16

Merge remote-tracking branch 'origin/master' into ci/add-python-3.10-…

757ee0e

…beta

⬆️ Upgrade pytest from 5.* to 6.*

abe7a56

Merge branch 'ci/add-python-3.10-beta' of github.com:Kludex/httpx int…

c8390f8

…o ci/add-python-3.10-beta

tomchristie reviewed Jun 14, 2021

View reviewed changes

Merge branch 'master' into ci/add-python-3.10-beta

b89fbc3

tomchristie merged commit 3231211 into encode:master Jun 15, 2021

tomchristie mentioned this pull request Jun 15, 2021

Switch CI to treat warnings as errors #1686

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

👷 Add Python 3.10 beta to the CI #1682

👷 Add Python 3.10 beta to the CI #1682

Kludex commented Jun 13, 2021 •

edited by tomchristie

Loading

tomchristie commented Jun 14, 2021

Kludex commented Jun 14, 2021

tomchristie commented Jun 14, 2021

Kludex commented Jun 14, 2021

tomchristie commented Jun 14, 2021 •

edited

Loading

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie Jun 14, 2021 •

edited

Loading

altendky Jun 14, 2021

altendky Jun 14, 2021

Kludex Jun 14, 2021

tomchristie Jun 14, 2021

tomchristie Jun 14, 2021 •

edited

Loading

Kludex Jun 14, 2021

tomchristie Jun 14, 2021

graingert commented Jun 14, 2021

pquentin commented Jun 15, 2021

tomchristie commented Jun 15, 2021

👷 Add Python 3.10 beta to the CI #1682

👷 Add Python 3.10 beta to the CI #1682

Conversation

Kludex commented Jun 13, 2021 • edited by tomchristie Loading

tomchristie commented Jun 14, 2021

Kludex commented Jun 14, 2021

tomchristie commented Jun 14, 2021

Kludex commented Jun 14, 2021

tomchristie commented Jun 14, 2021 • edited Loading

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie commented Jun 14, 2021

tomchristie Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

altendky Jun 14, 2021

Choose a reason for hiding this comment

altendky Jun 14, 2021

Choose a reason for hiding this comment

Kludex Jun 14, 2021

Choose a reason for hiding this comment

tomchristie Jun 14, 2021

Choose a reason for hiding this comment

tomchristie Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

Kludex Jun 14, 2021

Choose a reason for hiding this comment

tomchristie Jun 14, 2021

Choose a reason for hiding this comment

graingert commented Jun 14, 2021

pquentin commented Jun 15, 2021

tomchristie commented Jun 15, 2021

Kludex commented Jun 13, 2021 •

edited by tomchristie

Loading

tomchristie commented Jun 14, 2021 •

edited

Loading

tomchristie Jun 14, 2021 •

edited

Loading

tomchristie Jun 14, 2021 •

edited

Loading