Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1033 - Ensure that text that spans 3 invocations before newline is handled - don't clobber the buffer between invocations that haven't seen any lines. #1034

Merged
merged 5 commits into from
Jul 21, 2020

Conversation

scr
Copy link
Contributor

@scr scr commented Jun 24, 2020

Fixes #1033

scr-oath and others added 5 commits June 24, 2020 14:01
…newline is handled - don't clobber the buffer between invocations that haven't seen any lines.

This seems like a one character fix + the test.
@tomchristie
Copy link
Member

Fantastic stuff, thanks! Great spot wrt. trailing \r behaviour too, I've resolved that in #1075.

@tomchristie tomchristie merged commit ad5e6eb into encode:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiter_lines() doesn't return full lines that span multiple chunks
3 participants