Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Response.next() #1055

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Add missing Response.next() #1055

merged 1 commit into from
Jul 7, 2020

Conversation

florimondmanca
Copy link
Member

Motivation
Response.next() is documented in the developer docs but did not actually exist yet.

@florimondmanca florimondmanca added the bug Something isn't working label Jul 7, 2020
@florimondmanca florimondmanca requested a review from a team July 7, 2020 08:18
tomchristie
tomchristie approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot!

Had to ask myself "what's the async version here?", but happily our anext case does already exist, so that's covered.

@florimondmanca florimondmanca merged commit 3230cb3 into master Jul 7, 2020
@florimondmanca florimondmanca deleted the response-next branch July 7, 2020 08:54
@tomchristie tomchristie mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @tomchristie