Base URL improvements #1130
Merged
Base URL improvements #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
approved these changes
Aug 5, 2020
|
@tomchristie Should we pull the docs added in #1117 here as well? |
|
Yes, but I'm not 100% about the wording. Also I figure this is a bugfix either way, so let's get it in, and treat extra docs here as a nice-to-have. |
This was referenced Aug 5, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpx.URL().client.base_url = ...as a property.base_urljoining behaviour.So, an alternative implementation that closes #846, prompted by work in #1117.
The implementation here handles this by...
base_urlincludes a trailing slash on the path. Eg.https://www.example.com/subpath/./when joining relative URLs.This ends up given the behaviours you'd naturally expect from
base_urlusage, and also supports dotted paths, eg../foo/bar