Support header comparisons with dict or list. #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Sep 25, 2020
| @@ -23,7 +23,8 @@ def test_headers(): | |||
| assert dict(h) == {"a": "123, 456", "b": "789"} | |||
| assert repr(h) == "Headers([('a', '123'), ('a', '456'), ('b', '789')])" | |||
| assert h == httpx.Headers([("a", "123"), ("b", "789"), ("a", "456")]) | |||
| assert h != [("a", "123"), ("A", "456"), ("b", "789")] | |||
| assert h == [("a", "123"), ("A", "456"), ("b", "789")] | |||
| assert h == {"a": "123", "A": "456", "b": "789"} | |||
There was a problem hiding this comment.
To keep coverage at 100% we'll also need a test against a no-headers-like item.
Eg...
assert h != "a: 123\nA: 456\nb: 789"
tomchristie
reviewed
Sep 25, 2020
There was a problem hiding this comment.
Great, thanks!
There's also several other places in the test cases that could be fixed up too...
$ grep "== httpx.Headers" -r tests -n
tests/models/test_requests.py:29: assert request.headers == httpx.Headers(
tests/models/test_requests.py:39: assert request.headers == httpx.Headers(
tests/models/test_requests.py:52: assert request.headers == httpx.Headers(
tests/models/test_requests.py:76: assert request.headers == httpx.Headers(
tests/models/test_responses.py:47: assert response.headers == httpx.Headers(
tests/models/test_responses.py:60: assert response.headers == httpx.Headers(
tests/models/test_responses.py:74: assert response.headers == httpx.Headers(
tests/models/test_responses.py:88: assert response.headers == httpx.Headers(
tests/models/test_responses.py:745: assert response.headers == httpx.Headers({"Transfer-Encoding": "chunked"})
tests/models/test_responses.py:754: assert response.headers == httpx.Headers({"Content-Length": "8"})
tests/models/test_headers.py:25: assert h == httpx.Headers([("a", "123"), ("b", "789"), ("a", "456")])```
tomchristie
added
the
user-experience
|
Great, let me fix up. |
tomchristie
reviewed
Sep 25, 2020
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "python.pythonPath": "/Users/mus/Projects/httpx/venv/bin/python3" | |||
| } | |||
There was a problem hiding this comment.
We don't really want this file. You might want to setup a global gitignore to avoid including config that's specific to your local dev environment.
|
Fantastic stuff! 💚 |
|
I see my master is behind. Let me ff. |
|
Oh you did it. perfect! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows comparison of headers with dict or list:
Closes #1325