Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #1599.
Refs #1275.
Drop support for
QueryParams.__setitem__
andQueryParams.update()
in favour of an immutable-only interface, in line with ourURL
design. All manipulation methods now return new QueryParams instances:I've opted for a hard deprecation here, with
.update()
raising a RuntimeError, because immutability vs. mutability isn't something we ought to go "we're halfway there" on.