Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch copy_with #2185

Merged
merged 2 commits into from
May 3, 2022
Merged

Patch copy_with #2185

merged 2 commits into from
May 3, 2022

Conversation

lebr0nli
Copy link
Contributor

Patch for #2184

adamserafini
adamserafini reviewed May 2, 2022
View reviewed changes
Copy link

@adamserafini adamserafini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a test for this change?

@lebr0nli
Copy link
Contributor Author

lebr0nli commented May 2, 2022

Would it make sense to add a test for this change?

Yes, it makes sense.

I add a test for copy_with in the new commit to ensure copy_with won't change any URL property that the user didn't expect.

P.S. I think it's very hard to cover all scenarios, so I focus on preventing the possible attack vectors as far as I know.

@tomchristie tomchristie merged commit e9b0c85 into encode:master May 3, 2022
@dashk dashk mentioned this pull request May 7, 2022
Closed
@tomchristie tomchristie mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamserafini adamserafini adamserafini left review comments

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lebr0nli @tomchristie @adamserafini