replace pytest-asyncio and pytest-trio with anyio #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
graingert
commented
Dec 20, 2022
graingert
commented
- Initially raised as PR comment: Update pytest-asyncio #2511 (review)
graingert
commented
Dec 20, 2022
| @@ -152,7 +152,7 @@ async def async_auth_flow( | |||
| yield request | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
| @pytest.mark.anyio | |||
There was a problem hiding this comment.
is there a reason these were not marked @pytest.mark.usefixtures("async_environment") ?
There was a problem hiding this comment.
ah some of these tests used asyncio.Lock so only worked on asyncio. I changed it to anyio.Lock and they pass on trio or asyncio now
|
One less dependency gets my vote :) |
|
As a note, because @tomchristie mentioned before on Starlette that was not necessary, using I'm just mentioning, I'm not expressing my opinion. JFYK |
graingert
changed the title
tomchristie
reviewed
Dec 29, 2022
| @@ -18,7 +18,7 @@ combine_as_imports = True | |||
| addopts = -rxXs | |||
| filterwarnings = | |||
| error | |||
| asyncio_mode = strict | |||
| ignore: You seem to already have a custom sys.excepthook handler installed. I'll skip installing Trio's custom handler, but this means MultiErrors will not show full tracebacks.:RuntimeWarning | |||
There was a problem hiding this comment.
What's causing this warning, and when can we expect to be able to remove this filter?
tomchristie
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.