Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookies to the retried request when performing digest authentication. #2846

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

musale
Copy link
Member

@musale musale commented Sep 13, 2023

Summary

Adding the cookies from the response in the first request into the follow up request. The server expects a cookie to be set. This is however not highlighted in the RFC. Supporting SO answer and discussions by @robin-blanchard #2788 (comment).

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@tomchristie
Copy link
Member

Nicely done, thanks.

The test suite is failing because there's no coverage for this line...

Cookies(response.cookies).set_cookie_header(request=request)

Do you want to try adding a test case for this?

@musale
Copy link
Member Author

musale commented Sep 14, 2023

Nicely done, thanks.

The test suite is failing because there's no coverage for this line...

Cookies(response.cookies).set_cookie_header(request=request)

Do you want to try adding a test case for this?

Yes. I'll add a test for it.

@tomchristie tomchristie merged commit 88e8431 into encode:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants