Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop sniffio requirement. #3323

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Drop sniffio requirement. #3323

merged 4 commits into from
Sep 27, 2024

Conversation

tomchristie
Copy link
Member

Prompted by #2858 (review), thanks @T-256.

This is a more constrained part of #2858. I'll follow up with the remainder of that PR seperately.

Removes the sniffio requirement.

  • Where async detection is used in ASGI we can use a lazy optional import.
  • Usage in the _utils is overkill. The async implements just use time.perf_counter() anyway so let's switch to that.

@tomchristie tomchristie added enhancement New feature or request 1.0 proposal Pull requests proposing 1.0 API changes labels Sep 27, 2024
@tomchristie tomchristie merged commit 7a04661 into version-1.0 Sep 27, 2024
5 checks passed
@tomchristie tomchristie deleted the drop-sniffio-requirement branch September 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 proposal Pull requests proposing 1.0 API changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant