-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure JSON representation is compact. #3363 #3367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thx.
@@ -4,6 +4,7 @@ | |||
import pytest | |||
|
|||
import httpx | |||
from httpx._content import encode_json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed this accidentally snuck in a private import.
@BERRADA-Omar would you be up for refactoring these tests?
We can test this against public API using httpx.Request()
. Eg...
data = {...}
req = httpx.Request("POST", "https://www.example.com/", json=data)
assert req.content == ...
assert req.headers = ...
Summary
this PR solves the issues mentionned here #3363
Checklist