Skip to content

Commit

Permalink
move the slash around
Browse files Browse the repository at this point in the history
  • Loading branch information
Kludex committed Jul 7, 2023
1 parent ef04d1f commit 793c030
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion starlette/applications.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def build_middleware_stack(self) -> ASGIApp:
def routes(self) -> typing.List[BaseRoute]:
return self.router.routes

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
return self.router.url_path_for(name, **path_params)

async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
Expand Down
2 changes: 1 addition & 1 deletion starlette/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def state(self) -> State:
self._state = State(self.scope["state"])
return self._state

def url_for(self, /, name: str, **path_params: typing.Any) -> URL:
def url_for(self, name: str, /, **path_params: typing.Any) -> URL:
router: Router = self.scope["router"]
url_path = router.url_path_for(name, **path_params)
return url_path.make_absolute_url(base_url=self.base_url)
Expand Down
12 changes: 6 additions & 6 deletions starlette/routing.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class BaseRoute:
def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
raise NotImplementedError() # pragma: no cover

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
raise NotImplementedError() # pragma: no cover

async def handle(self, scope: Scope, receive: Receive, send: Send) -> None:
Expand Down Expand Up @@ -258,7 +258,7 @@ def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
return Match.FULL, child_scope
return Match.NONE, {}

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
seen_params = set(path_params.keys())
expected_params = set(self.param_convertors.keys())

Expand Down Expand Up @@ -333,7 +333,7 @@ def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
return Match.FULL, child_scope
return Match.NONE, {}

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
seen_params = set(path_params.keys())
expected_params = set(self.param_convertors.keys())

Expand Down Expand Up @@ -415,7 +415,7 @@ def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
return Match.FULL, child_scope
return Match.NONE, {}

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
if self.name is not None and name == self.name and "path" in path_params:
# 'name' matches "<mount_name>".
path_params["path"] = path_params["path"].lstrip("/")
Expand Down Expand Up @@ -493,7 +493,7 @@ def matches(self, scope: Scope) -> typing.Tuple[Match, Scope]:
return Match.FULL, child_scope
return Match.NONE, {}

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
if self.name is not None and name == self.name and "path" in path_params:
# 'name' matches "<mount_name>".
path = path_params.pop("path")
Expand Down Expand Up @@ -652,7 +652,7 @@ async def not_found(self, scope: Scope, receive: Receive, send: Send) -> None:
response = PlainTextResponse("Not Found", status_code=404)
await response(scope, receive, send)

def url_path_for(self, /, name: str, **path_params: typing.Any) -> URLPath:
def url_path_for(self, name: str, /, **path_params: typing.Any) -> URLPath:
for route in self.routes:
try:
return route.url_path_for(name, **path_params)
Expand Down
2 changes: 1 addition & 1 deletion starlette/templating.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _create_env(
**env_options: typing.Any,
) -> "jinja2.Environment":
@pass_context
def url_for(context: dict, /, name: str, **path_params: typing.Any) -> URL:
def url_for(context: dict, name: str, /, **path_params: typing.Any) -> URL:
request = context["request"]
return request.url_for(name, **path_params)

Expand Down

0 comments on commit 793c030

Please sign in to comment.