-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UJSONResponse #1047
Remove UJSONResponse #1047
Conversation
ac8155e
to
aed4628
Compare
I'm all in for that removal ! |
aed4628
to
1e5602b
Compare
@euri10 I wrote a bit about custom JSON serialization in |
looks perfect ! 👍 |
Fab yup! |
@JayH5, this would have been a good one to include in the |
@erewok yeah sorry, I didn't want it to get in the way of all the fixes in "0.13.9" and then when we switched to 0.14 I forgot about it. Happy to squeeze it in if you want to do that? I won't be able to organise a release right now (haven't actually done one before), but if you want to merge this and do one be my guest. |
@JayH5, no worries! I do think we could take advantage of the "breaking change" version bump to merge this (and probably any other test or documentation changes that are easily to include) and make another release. Would you be up for merging this and issuing a release? (For reference: https://www.python-httpx.org/contributing/#releasing) |
I don't see any other obvious candidate PRs. Will give this a go. |
- ujson was dropped in encode/starlette#1047 - test_debug_html was fixed in encode/starlette#1132
Closes #901
It's easy enough to implement your own UJSONResponse response class if you need it: