Fix functools.partial async handlers for classmethods #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayH5
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Hey @vladmunteanu sorry for the slow response on this. If you're still interested in this change & around we could try squeeze this into a bugfix release soon?
Co-authored-by: Jamie Hewland <jhewland@gmail.com>
|
@JayH5 I'd really appreciate this being released, so I went with your suggestion to keep things simple. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was my fault for not properly checking all of the cases when I added #984. Apparently, on Python 3.8, partials of classmethods are still not correctly identified as coroutines.
An attempt to fix #1107