Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebSocketException and support for WS handlers #1263

Merged
merged 20 commits into from
Sep 5, 2022
Merged

Add WebSocketException and support for WS handlers #1263

merged 20 commits into from
Sep 5, 2022

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Aug 11, 2021 •
edited
Loading

Missing

image

  • Check how this PR works interacting with the server.

@Kludex Kludex mentioned this pull request Dec 6, 2021
Closed
@aminalaee aminalaee mentioned this pull request Jan 27, 2022
Closed
@adriangb
Copy link
Member

@Kludex just fyi I updated this branch and fixed all issues

@Kludex
Copy link
Member Author

Kludex commented Jan 27, 2022

don't worry :)

@adriangb adriangb added the feature New feature or request label Feb 2, 2022
@nameer
Copy link

nameer commented Feb 28, 2022

Any updates?

nameer
nameer reviewed Feb 28, 2022
View reviewed changes
starlette/exceptions.py Outdated Show resolved Hide resolved
@brunopcarv
Copy link

Any updates or help needed on this?

@obonyojimmy
Copy link

Any updates on this ?

@Kludex
Copy link
Member Author

Kludex commented Apr 14, 2022

No.

@Kludex
Copy link
Member Author

Kludex commented Apr 21, 2022

Update here: I'll be working on this on the following weeks. If my memory doesn't fail me, this PR should be completed, but I need to implement something (which I don't know what, I need to check) on uvicorn.

@Kludex Kludex added this to the Version 0.2x.x milestone Apr 21, 2022
@Kludex Kludex modified the milestones: Version 0.21.0, Version 0.22.0 May 5, 2022
@Kludex Kludex marked this pull request as ready for review May 10, 2022 05:45
@Kludex Kludex force-pushed the feat/websockets-exception branch from ade417f to 41b06d2 Compare May 10, 2022 05:49
@Kludex
Copy link
Member Author

Kludex commented May 10, 2022

I've rebased the PR, add the reason field on the WebSocketException, and updated the PR description.

@Kludex Kludex added the websocket WebSocket-related label May 10, 2022
@Kludex Kludex self-assigned this May 10, 2022
@Kludex Kludex removed this from the Version 0.21.0 milestone Jun 12, 2022
@Kludex Kludex added this to the Version 0.22.0 milestone Jun 12, 2022
@nameer
Copy link

nameer commented Aug 12, 2022

Any update on this one?

@Kludex
Copy link
Member Author

Kludex commented Aug 12, 2022

No.

@Kludex
Copy link
Member Author

Kludex commented Aug 12, 2022

I'm going to work on this.

@Kludex Kludex modified the milestones: Version 0.22.0, Version 0.21.0 Aug 12, 2022
@Kludex Kludex changed the title Add WebSocketException and support for WS handlers Add WebSocketException and support for WS handlers Aug 13, 2022
@Kludex
Copy link
Member Author

Kludex commented Aug 13, 2022

This PR is completed.

@tomchristie Would you mind checking it?

Considering the comment you made (described in the description), I've removed the logic from the ServerErrorMiddleware. Instead, I've created a follow-up on Kludex#22, do you think that makes sense?

@Kludex Kludex requested a review from a team August 13, 2022 14:17
@Kludex Kludex mentioned this pull request Aug 18, 2022
Merged
8 tasks
tiangolo
tiangolo approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

tomchristie
tomchristie approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, yes.

@Kludex
Copy link
Member Author

Kludex commented Sep 5, 2022

Thanks @tomchristie @tiangolo 🎉

@Kludex Kludex merged commit d525431 into encode:master Sep 5, 2022
aminalaee pushed a commit that referenced this pull request Feb 13, 2023
@Kludex @tiangolo
@adriangb @tomchristie @aminalaee
Add WebSocketException and support for WS handlers (#1263)
299b5e4 
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
@mnixry mnixry mentioned this pull request Aug 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nameer nameer nameer left review comments

@tiangolo tiangolo tiangolo approved these changes

@tomchristie tomchristie tomchristie approved these changes

Assignees

@Kludex Kludex

Labels
feature New feature or request websocket WebSocket-related
Projects
None yet
Milestone
Version 0.21.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kludex @adriangb @nameer @brunopcarv @obonyojimmy @tomchristie @tiangolo