New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch more general`BaseException` instead of `Exception` #1328

Closed

mbergal wants to merge 1 commit into encode:master from mbergal:fix/server-error-middleware-exception-handling

mbergal commented Nov 2, 2021

anyio.ExceptionGroup, for example, is not an Exception but is a BaseException


          Catch more generalBaseException instead of Exception

311982b

Author

mbergal commented Nov 2, 2021

Might be not super relevant after 6c9bc55?diff=split

Member

Kludex commented Nov 2, 2021

I think we don't want to merge this even if #1262 didn't land.

You can read more about it on https://www.python.org/dev/peps/pep-0352/

But thanks for the PR! 😄

Kludex closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet