Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Debug extension #1991

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Support Debug extension #1991

merged 4 commits into from
Feb 6, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Dec 30, 2022

@Kludex Kludex requested review from a team and adriangb December 30, 2022 14:22
@Kludex Kludex added this to the Version 0.24.0 milestone Jan 7, 2023
@Kludex
Copy link
Member Author

Kludex commented Feb 4, 2023

@encode/maintainers I need a review here. 👀

@Kludex Kludex mentioned this pull request Feb 4, 2023
Merged
7 tasks
florimondmanca
florimondmanca approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great, congratulations on getting it standardized via the ASGI spec. I like the generality of it, too. Definitely a better state of things than the previous http.response.template extension!

@Kludex
Copy link
Member Author

Kludex commented Feb 5, 2023

I think this is great, congratulations on getting it standardized via the ASGI spec. I like the generality of it, too. Definitely a better state of things than the previous http.response.template extension!

Thanks! 😁❤️

@Kludex Kludex merged commit ca1711f into master Feb 6, 2023
@Kludex Kludex deleted the fix/add-debug-extension-support branch February 6, 2023 05:31
aminalaee pushed a commit that referenced this pull request Feb 13, 2023
@Kludex @aminalaee
Support Debug extension (#1991)
d04e3f8
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@adriangb adriangb Awaiting requested review from adriangb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.24.0
Development

Successfully merging this pull request may close these issues.

AssertionError with middleware and TemplateResponse
2 participants
@Kludex @florimondmanca