Allow "name" argument on url_for() and url_path_for()
#2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Mar 1, 2023
Kludex
commented
- Closes "url_for" signature prevents use of "name" in path arguments #608
- Replaces allow 'name' in key word arguments of url_for() and url_path_for() (#608) #611
Co-authored-by: Daniel <709115+dansan@users.noreply.github.com>
|
@encode/maintainers 👀 🙏 |
|
This looks good to me. But admittedly I don't really use this functionality so I'd like someone who actually uses this to be the one approving ✅ |
|
I want to make a premature release with the lifespan state that was included, but since I included #1385, it may be good to also include this in the release. 😅 @alex-oleshkevich @abersheeran would you mind checking this? 🙏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.