Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Response.render content argument typing #2264

Merged

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Sep 1, 2023

Summary

Fixes #2242
According to #2242 (comment)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@aminalaee aminalaee force-pushed the change-response-render-content-typing branch from ae89db8 to 3e111a2 Compare September 1, 2023 08:13
starlette/responses.py Outdated Show resolved Hide resolved
starlette/responses.py Outdated Show resolved Hide resolved
@aminalaee aminalaee force-pushed the change-response-render-content-typing branch from 3e111a2 to 6e76c5a Compare September 1, 2023 08:22
@aminalaee aminalaee merged commit bc7d095 into encode:master Sep 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liskov substitution problems in new Response.render type signature
2 participants