Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if "extensions" in scope before checking the extension #2438

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Check if "extensions" in scope before checking the extension #2438

merged 1 commit into from
Jan 23, 2024

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jan 23, 2024

@Kludex Kludex requested a review from a team January 23, 2024 07:17
iudeen
iudeen approved these changes Jan 23, 2024
View reviewed changes
Copy link

@iudeen iudeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kludex Kludex merged commit e54be85 into master Jan 23, 2024
5 checks passed
@Kludex Kludex deleted the extensions-is-opt branch January 23, 2024 07:42
@nbr23 nbr23 mentioned this pull request Jan 23, 2024
Closed
nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
@Kludex
Check if "extensions" in scope before checking the extension (encode#…
793e7d1 
…2438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iudeen iudeen iudeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kludex @iudeen