Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Resolve the issue where the directory itself being a symlink does not work. #2711

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix: Resolve the issue where the directory itself being a symlink does not work. #2711

merged 1 commit into from
Dec 1, 2024

Conversation

hanxi
Copy link
Contributor

@hanxi hanxi commented Sep 29, 2024

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Fixed #2646

I test GHSA-v5gw-mw7f-84px case. test result is 404 Not Found.

@hanxi hanxi mentioned this pull request Sep 29, 2024
Closed
@Kludex
Copy link
Member

Kludex commented Sep 29, 2024

A test case is needed here.

@hanxi
Copy link
Contributor Author

hanxi commented Sep 30, 2024

Okay, I'll add the test cases.

@hanxi
Copy link
Contributor Author

hanxi commented Sep 30, 2024

done.

@Kludex Kludex merged commit eee4cdc into encode:master Dec 1, 2024
6 checks passed
@Kludex
Copy link
Member

Kludex commented Dec 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the directory itself being a symlink does not work.
2 participants
@hanxi @Kludex