#493 and #495 cache body content #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! So we may do something like this at some point, but we'll want to have a more comprehensive look at it - eg. what should the behaviour look like when consuming the request body as a stream. At the moment I'd like us to punt on this, but there's likely somethere here we'll come back to. |
nav
added a commit
to nav/starlette
that referenced
this pull request
Feb 26, 2020
nav
added a commit
to nav/starlette
that referenced
this pull request
Jul 9, 2020
nav
added a commit
to nav/starlette
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dear developers, not sure if it is 100% compliant with your code base, but I'll be more than welcome to refactor it if not. This is one of the tests that I did locally in order to be able to consume the Request.Body more than one time when recreating a Request object from the Scope, this fix is caching the body content inside the scope rather than a local variable.