Fix reload process behavior when exception is raised (#1313)

* Fix reload process behavior when exception is raised * Remove test introduced by change
encode · Jan 11, 2022 · c6a7db5 · c6a7db5
1 parent 566e63e
commit c6a7db5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -122,21 +122,6 @@ def test_cli_incomplete_app_parameter() -> None:
     assert result.exit_code == 1
 
 
-def test_cli_reloader_incomplete_app_parameter(
-    capfd: pytest.CaptureFixture[str],
-) -> None:
-    runner = CliRunner()
-
-    runner.invoke(cli, ["tests.test_cli", "--reload"])
-
-    captured = capfd.readouterr()
-
-    assert (
-        'Error loading ASGI app. Import string "tests.test_cli" '
-        'must be in format "<module>:<attribute>".'
-    ) in captured.err
-
-
 @pytest.fixture()
 def load_env_h11_protocol():
     old_environ = dict(os.environ)

diff --git a/uvicorn/supervisors/basereload.py b/uvicorn/supervisors/basereload.py
@@ -45,9 +45,6 @@ def run(self) -> None:
             if self.should_restart():
                 self.restart()
 
-            if self.process.exitcode is not None:
-                break
-
         self.shutdown()
 
     def startup(self) -> None: