Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage-conditional-plugin setup #1260

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Nov 22, 2021

Remake of #1159

Related to #1157 and #102

I've accidentally deleted my fork, so I'll have to recreate some PRs, jfyk.

@euri10 @tomchristie What do you think about this?

@euri10
Copy link
Member

euri10 commented Nov 23, 2021

I think it's cool

@tomchristie
Copy link
Member

Yeah I don't have a problem with that.

@Kludex
Copy link
Member Author

Kludex commented Nov 23, 2021

Cool! With this I'll try to push forward the 100% coverage in the following weeks :)

If no further complains, would someone be gentle to approve this? 🙏

@Kludex
Copy link
Member Author

Kludex commented Nov 23, 2021

Thanks @euri10 :)

@Kludex Kludex merged commit 7504f66 into encode:master Nov 23, 2021
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants