Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(signal): add sleep to ensure shutdown completion #2427

Merged
merged 1 commit into from
Aug 13, 2024
Merged

test(signal): add sleep to ensure shutdown completion #2427

merged 1 commit into from
Aug 13, 2024

Conversation

vvanglro
Copy link
Contributor

Summary

#2382

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Member

Kludex commented Aug 13, 2024

Is this about the hanging test?

@vvanglro
Copy link
Contributor Author

Is this about the hanging test?

No, is a patch to 2382. Increases stability of signal tests
https://github.com/encode/uvicorn/actions/runs/10365937979/job/28694114428

https://github.com/encode/uvicorn/actions/runs/10365916920/job/28694050767

@Kludex Kludex merged commit cee31a6 into encode:master Aug 13, 2024
15 checks passed
@Kludex
Copy link
Member

Kludex commented Aug 13, 2024

Thanks 🙏

@vvanglro
Copy link
Contributor Author

Later I will investigate why the test is hanging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvanglro @Kludex