Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using uvicorn to start, programmaticly, multiple servers.
But logs were always uvicorn.error or uvicorn.access.
I need to make a difference regarding the source server emitting the log.
I added an optional parameter in Config constructor to allow overriding the loggers names.
And i patched the code to use the logger coming from Config instead of using global objects.
So, as an example, adding this parameter
logger_mappings = { "general": "mylogger.general", "access": "mylogger.access", "asgi": "mylogger.asgi", }
to the Config constructor shall configure the logging in the correct loggers.
I did hack a bit the Config object to maintain maximum compatibility with existing code.
PS: If you find my code is ugly, i agree and i'm willing to improve it.
PS2: Forgive my english