Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override the root logger #674

Merged
merged 1 commit into from
May 15, 2020
Merged

Don't override the root logger #674

merged 1 commit into from
May 15, 2020

Conversation

stchris
Copy link
Contributor

@stchris stchris commented May 15, 2020

Overriding the root logger is probably not intended here.

This is just a PR for the fix proposed in #630

@stchris
Don't override the root logger
a4ffed0 
Overriding the root logger is probably not intended here. See discussion in encode#630
tomchristie
tomchristie approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomchristie
Copy link
Member

Thanks!

@tomchristie tomchristie merged commit e382440 into encode:master May 15, 2020
@euri10 euri10 mentioned this pull request Jul 22, 2020
Closed
@br3ndonland br3ndonland mentioned this pull request Aug 20, 2020
Merged
1 task
@kigawas kigawas mentioned this pull request Aug 27, 2020
Merged
@florimondmanca florimondmanca mentioned this pull request Dec 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stchris @tomchristie