Log exception traceback in case of invalid HTTP request when using h11 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
approved these changes
Dec 12, 2020
euri10
added a commit
to euri10/uvicorn
that referenced
this pull request
Jun 13, 2022
…using h11 (encode#889)" This reverts commit 2e17dd9
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
…e#1518) * Revert "Log exception traceback in case of invalid HTTP request when using h11 (encode#889)" This reverts commit 2e17dd9 * Revert "Log exception traceback in case of invalid HTTP request when using httptools (encode#886)" This reverts commit 305ed0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #886, adding the same behavior for
h11. Figured this could also be helpful someday!