🐛 Fix resetting signals in Gunicorn UvicornWorker #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix subprocesses that capture output having an incorrect returncode
2 tasks
euri10
reviewed
Dec 16, 2020
florimondmanca
approved these changes
Dec 29, 2020
Merged
|
Woohoo! Thanks @florimondmanca for checking, updating, and merging this! 🚀 🤓 🍰 ☕ |
This was referenced Jan 1, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix resetting signals in Gunicorn
UvicornWorkerto fix subprocesses that capture output having an incorrectreturncode.Fixes #894
Very short version:
When starting Gunicorn with Uvicorn worker(s), if the app uses
subprocessto start other processes and captures the output, theirreturncodeis in most cases0, even if the actual exit code was1.Lengthy explanation and self-contained reproducible example in this issue: #894