Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update php unit test workflow to run in docker #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aspencer
Copy link
Contributor

@aspencer aspencer commented Dec 6, 2023

Description

This change adds additional steps to support running php tests inside of a docker container

Jira Issue: https://revolutionparts.atlassian.net/browse/DEVX-700

Background

Working through changes in the file-scan-daemon, I needed to run tests inside of a docker container. In order to do THAT, I needed a way to run health checks and wait for a docker container to become ready.

Input Changes:

  • run_docker - turn on to run tests inside of a docker container
  • health_check_command - specific to each application, command to run to determine whether the container is ready (example)
  • health_check_timeout - how many seconds to wait for the container to be ready (defaults to 5 mins)

Workflow Changes:
3 new workflow steps, all gated behind the run_docker flag. Most notably, the wait command, which loops through and checks to see whether or not the container is ready to run tests.

Testing Information

Battle-Tested this over on the file-scan-daemon repo, working off a copy that I'm now moving back here.

@aspencer aspencer requested a review from a team as a code owner December 6, 2023 16:28
@aspencer aspencer requested review from dpiasecki-rp and paulredmond and removed request for dpiasecki-rp December 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants